public/atlantis
1
0
Fork 0
mirror of https://git.vectorsigma.ru/public/atlantis.git synced 2026-08-04 04:19:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #10. Renaming for consistency (#12)

Browse Source 
Repo owner, name => repoFullName
PullID => PullNum to match GitHub API
PR => Pull to match GitHub API and avoid writing PRID anywhere
This commit is contained in:
Luke Kysow
2017-05-31 16:46:49 -07:00
committed by GitHub
parent 5341b77063
commit 0cb13a9e85
12 changed files with 104 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
request_parser.go
View File

@@ -68,13 +68,9 @@ func (r *RequestParser) determineCommand(comment *github.IssueCommentEvent) (*Co
func (r *RequestParser) extractCommentData(comment *github.IssueCommentEvent, params *ExecutionContext) error {
missingField := "<nil>"
owner := comment.Repo.Owner.Login
if owner == nil {
return errors.New("key 'comment.repo.owner.login' is null")
}
repoName := comment.Repo.Name
if repoName == nil {
return errors.New("key 'comment.repo.name' is null")
repoFullName := comment.Repo.FullName
if repoFullName == nil {
return errors.New("key 'comment.repo.full_name' is null")
}
pullNum := comment.Issue.Number
if pullNum == nil {
@@ -102,10 +98,9 @@ func (r *RequestParser) extractCommentData(comment *github.IssueCommentEvent, pa
}
params.requesterUsername = *commentorUsername
params.requesterEmail = *commentorEmail
params.repoOwner = *owner
params.repoFullName = *repoFullName
params.pullNum = *pullNum
params.pullCreator = *pullCreator
params.repoName = *repoName
params.repoSSHUrl = *repoSSHURL
params.htmlUrl = *htmlURL
return nil