public/atlantis
1
0
Fork 0
mirror of https://git.vectorsigma.ru/public/atlantis.git synced 2026-07-29 00:48:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Set mergeable correctly when branch protection doesn't require reviewers (#2470)

Browse Source 
* Allow no required reviewers

* Fix comment in tests

Co-authored-by: Stas Ostrovskyi <stasostrovskyi@users.noreply.github.com>
This commit is contained in:
Stas Ostrovskyi
2022-09-08 22:54:50 +02:00
committed by GitHub
parent 178e4a4c09
commit b8297bb1f8
4 changed files with 338 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
server/events/vcs/github_client.go
View File

@@ -365,7 +365,7 @@ func (g *GithubClient) GetPullReviewDecision(repo models.Repo, pull models.PullR
return approvalStatus, errors.Wrap(err, "getting reviewDecision")
}
if query.Repository.PullRequest.ReviewDecision == "APPROVED" {
if query.Repository.PullRequest.ReviewDecision == "APPROVED" || len(query.Repository.PullRequest.ReviewDecision) == 0 {
return true, nil
}