In this particular example `mr.HeadPipeline.SHA` panics on a nil pointer dereference because HeadPipeline is empty.
This seems to be caused by the lack of permission to update the commit status.
```go
runtime.gopanic
runtime/panic.go:1038
runtime.panicmem
runtime/panic.go:221
runtime.sigpanic
runtime/signal_unix.go:735
github.com/runatlantis/atlantis/server/events/vcs.(*GitlabClient).PullIsMergeable
github.com/runatlantis/atlantis/server/events/vcs/gitlab_client.go:208
github.com/runatlantis/atlantis/server/events/vcs.(*ClientProxy).PullIsMergeable
github.com/runatlantis/atlantis/server/events/vcs/proxy.go:72
github.com/runatlantis/atlantis/server/events/vcs.(*pullReqStatusFetcher).FetchPullStatus
github.com/runatlantis/atlantis/server/events/vcs/pull_status_fetcher.go:28
github.com/runatlantis/atlantis/server/events.(*ApplyCommandRunner).Run
github.com/runatlantis/atlantis/server/events/apply_command_runner.go:105
github.com/runatlantis/atlantis/server/events.(*DefaultCommandRunner).RunCommentCommand
github.com/runatlantis/atlantis/server/events/command_runner.go:252
```
The least invasive solution is to simply use the commit-hash from pull and guess that the pipeline was "skipped" unless the HeadPipeline is there.
The outcome is:
When mr.HeadPipeline is present:
- use the commit hash and status from the HeadPipeline
When mr.HeadPipeline is NOT present:
- use the commit hash from pull request struct
- assume the pipeline was "skipped"
In cases where GitLab is configured to require a pipeline to pass, this results on a message saying the MR is not mergeable.
More info:
- https://github.com/runatlantis/atlantis/issues/1852
* Bump to atlantis-base:2022.11.13
* Use cimg/go back image
* Use correct path of cimg/go binary dir
* e2e: use /usr/bin
* e2e: add set -e
* circleci: use testing-env:2022.11.13
* e2e: use /home/circleci/go/bin
* e2e: revert to testing-env:2021.08.31 image
* Update go-generate to run as a script
It was taking forever to run via the previous Makefile command. I don't
exactly know why. Perhaps because it was passing all the packages in as
multiple arguments?
Either way, this change allows it to actually run through in about 20
minutes.
* Regenerate all mocks using latest pegomock
Pegomock version v2.9.0
* Format mocks outside of regular mocks directory.
These mocks are outside of the regular directory due to an import cycle
causing us to have to have these not under a /mocks directory so they
need to be formatted since they're not excluded.
* Add back make test target
Hashicorp has recently added arm64 builds with their recent 0.14
release: https://www.hashicorp.com/blog/announcing-hashicorp-terraform-0-14-general-availability
> Terraform 0.14 also adds official support for Linux ARM64 builds.
> We’ve gone further and added Linux ARM64 support in the latest 0.13.x releases.
Similarly, recent versions of popular providers are also published with
arm64 builds.
This change updates the build script in order to produce an arm64
binary.
This would be useful, for example, for running in the cloud with one of
Amazon graviton2 instance types, or at a smaller scale on a Raspberry Pi
3 (or newer).
To be clear, Atlantis was compatible with 0.12 before this commit, but
this change makes 0.12 the default version *if* users haven't set the
--default-tf-version flag.
Bootstrap is meant for a system that sets itself up. This command is
more like a testing mode so I want to rename it to avoid confusion.
Fixes#129 and came out of #117.
* Adding docker image and release scripts
* Using circleci version 2
* now building dumb-init and gosu from source
* trying to fix e2e tests
* fixing working directory for circleci version 2
* start atlantis server and ngrok in the background
* Adding terraform to path and removing old decryption method for circleci
* adding terraform binary to the correct path
* ATLANTIS_URL is now being exported
* using circleci version 2 syntax to export variable
* using circleci version 2 syntax to export variable
* ngrok isnt working now
* Updating CHANGELOG
* Fixes after review and updated README.md
* Adding e2e tests back and upgrading terraform version 0.9.11
* Fixing the binary name for e2e tests
* revert binary name change
* missed indentation for makefile
* use owner name for branch head for pull request creation
* Adding the ability to get lock data and show it using the detail view in the ui for boltdb
* adding modal style
* Adding new modal based discard ui
* Adding detail view and get lock funtionality with unlocking with the UI
* lots of clean up after review
* using jquery most places now
* missed in merge
* this should cause a build failure
* moving e2e test as part of the test override step so they run if unit tests fail
* fixing boltdb tests
* turns out you can't fail fast in circleci
* don't compare locks
