This has the potential to speed up rebuilds of the Atlantis container
significantly, especially for non-x86 platforms which are emulated when
done in GitHub Actions.
It works by using cache mounts:
https://docs.docker.com/engine/reference/builder/#run---mounttypecache.
They mean we can have specific paths set that are carried over from one
image build to the next, regardless of which files are changed in the
project. The files are however at the same time not part of the final
image, which reduces the generated "builder" image from 1.66 GB to just
386 MB on the current main branch.
In my local tests, which doesn't make use of emulation, I saw a drop
for the "go build" step going from taking just over 40 seconds with an
empty cache to around 1 second when I make a one character change to a
Go source file. That is otherwise a change that prior to this would
cause a complete rebuild of the Docker image layer.
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
* Bump to atlantis-base:2022.11.13
* Use cimg/go back image
* Use correct path of cimg/go binary dir
* e2e: use /usr/bin
* e2e: add set -e
* circleci: use testing-env:2022.11.13
* e2e: use /home/circleci/go/bin
* e2e: revert to testing-env:2021.08.31 image
* fix(docker): fix base image for multi-platform build (#2099)
* Correct indentation of run commands
* Split installation of packages into the ones needed at run time and build time
This allows us to now repeat the packages which need to be uninstalled again by
making use of a virtual package, which - when removed - removes the packages
installed as a dependency of it.
* Remove unnecessary `rm -rf /var/cache/apk/*` command
It's no needed when `apt add` is run with the `--no-cache` option.
* Add vertical spacing so it's clearer what is happening when
* Test the downloaded binaries to make sure they work on the platform
This can help find issues where binaries are downloaded for the wrong platform
compared to the architecture the Docker image is built for.
* Install dumb-init via apk
It's available as a package for Alpine Linux in version 1.2.5 as well, which
makes it easier to handle for the different architectures.
* Get git-lfs binaries in the right architecture for the Docker image
This makes use of the `TARGETPLATFORM` argument which automatically is
populated by Docker BuildKit with a string such as "linux/amd64" when the image
is being build for an x86_64 architecture.
* Install gosu for the right architecture
The `case` statement was taken from
https://github.com/BretFisher/multi-platform-docker-build as a way of
translating the platform name into what we needed for downloading gosu.
* fix(docker): fix installation of git-lfs in armv7 image (#2100)
This uses a similar pattern than what is used for `GOSU_ARCH` to map the
`TARGETPLATFORM` argument into the name of the architecture git-lfs use for
their release binaries, as "linux/arm/v7" otherwise would be mapped into "v7"
which is wrong.
* fix(docker): download Terraform and conftest versions maching image architecture (#2101)
* Remove Terraform versions from Docker image which don't have all archs
Terraform versions earlier than 0.11.15 does not have binaries available for
both amd64, arm64 and armv7, so are being dropped as we can't install the older
versions in all the architectures the Docker image is built for.
* Download Terraform version depending on the architecture Docker image is for
This avoids us having arm64 binaries for the ARM Docker images, which won't
work.
* Download arm64 conftest binaries for arm64 Docker image
This doesn't fix the armv7 Docker image because conftest doesn't have a binary
available for that, so it for now still downloads the x86_64 binary, which is
likely to not work - but it's the same as it did before.
* Correct path to dumb-init in docker-entrypoint.sh
The path changed after dumb-init was switched to be installed via `apk` rather
than downloaded directly as a binary.
* Remove Terraform versions from Docker image which don't have all archs
Terraform versions earlier than 0.11.15 does not have binaries available for
both amd64, arm64 and armv7, so are being dropped as we can't install the older
versions in all the architectures the Docker image is built for.
* Download Terraform version depending on the architecture Docker image is for
This avoids us having arm64 binaries for the ARM Docker images, which won't
work.
* Download arm64 conftest binaries for arm64 Docker image
This doesn't fix the armv7 Docker image because conftest doesn't have a binary
available for that, so it for now still downloads the x86_64 binary, which is
likely to not work - but it's the same as it did before.