- Remove newline characters from error messages in step.go
- Change capitalized error messages to lowercase in multienv_step_runner.go and github_client.go
- Replace all strings.Replace with strings.ReplaceAll
- Fix all De Morgan's law and tagged switch issues
- Remove empty branches, clarify comments
- Fix error string capitalization and punctuation
- Use assert.Len for testifylint
- Remove embedded field selector warnings
This should allow golangci-lint to pass cleanly on the renovate branch.
* Make code more Go-idiomatic
While at it makes it more readable.
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
* Add internal function to parse multienv step input
This new function properly deals with quotes and commas in values.
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
* Add regression test for multienv output with comma in values
See #2765 for an issue report.
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
* Use parseMultienvLine for parsing multienv steps output
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
* Add internal function to parse multienv step input
This new function properly deals with quotes and commas in values.
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
---------
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
* Fix multienv command
Correctly handles environment variable values that themselves contain "=" (e.g. AWS session tokens)
Ensures that trailing "\n" does not get published as part of the last environment variables value.
* Correct check for empty result in multienv
Check the length of the result string instead of splitting it first and checking the length of envvars (since split always returns an array of length 1)
Co-authored-by: Marc Hildenbrand <mwhildenbrand@gmail.com>
* Update multienv_step_runner Env Var Parsing Logic
* Update multienv_step_runner.go to split only on the first = character
* Add affirmative and failing test cases
* Run gofmt
* Start threading job output to RunStepRunner
* Strip ANSI
* Fix lint
* Use waitgroup to avoid test flakiness
* Move waitgroup higher
* Add ANSI test and use strings.Builder
* Fix lint
* Use errors.Wrap per style guide
* Create ShellCommandRunner to encapsulate streaming
* WIP: shell command runner
* Update signatures to propagate error finding version
* Fix log output
* Fix error checking
* Fix accidental whitespace stripping
* Remove unused struct field
* Fix error checking in terraform client
* Add unit tests to verify command output handler was called
* Remove err from async interface
* Remove duplicative log now that shell command runner does it
* Hide output in stream for env/multienv
* Add comment explaining goroutines
* Use printf for better macOS compatibility
