Commit Graph

121 Commits

Author SHA1 Message Date
PePe Amengual
02ffb41cd6 fix: resolve remaining staticcheck linting issues
- Remove newline characters from error messages in step.go
- Change capitalized error messages to lowercase in multienv_step_runner.go and github_client.go
2025-06-27 12:22:14 -07:00
PePe Amengual
d13bb002b3 fix: resolve test failures after golangci-lint updates
- Fix terraform lock file checksum verification by updating with correct checksums for null provider v3.2.4
- Fix GitLab request parser validation errors by removing nolint comments from JSON test data
- Fix step validation error messages by adding missing newlines
- Fix MultiEnv step runner error messages by capitalizing 'Invalid'
- Fix GitHub client merge method error messages by capitalizing 'Merge method' and 'Specify'

All tests now pass successfully.
2025-06-27 12:11:55 -07:00
PePe Amengual
03467ec811 fix: address all remaining golangci-lint staticcheck issues (ReplaceAll, error strings, empty branches) 2025-06-27 11:58:40 -07:00
PePe Amengual
392d5165a9 fix: resolve all linter issues for golangci-lint v1.54+
- Replace all strings.Replace with strings.ReplaceAll
- Fix all De Morgan's law and tagged switch issues
- Remove empty branches, clarify comments
- Fix error string capitalization and punctuation
- Use assert.Len for testifylint
- Remove embedded field selector warnings

This should allow golangci-lint to pass cleanly on the renovate branch.
2025-06-27 11:27:55 -07:00
Ricard Bejarano
4a44c3cfb1 fix: Remove GitHub rate-limit client total sleep limit (#5591)
Signed-off-by: Ricard Bejarano <ribejara@thousandeyes.com>
2025-05-22 10:49:10 -07:00
Ricard Bejarano
6c129199d6 fix: only allow team slug support in --gh-team-allowlist by dropping support for ambiguous team names (#5510)
Signed-off-by: Ricard Bejarano <ricard@bejarano.io>
Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com>
Co-authored-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: RB <7775707+nitrocode@users.noreply.github.com>
2025-04-12 17:39:21 -05:00
renovate[bot]
b3b3f5ab43 fix(deps): update module github.com/google/go-github/v68 to v71 in go.mod (main) (#5522)
Signed-off-by: RB <7775707+nitrocode@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: RB <7775707+nitrocode@users.noreply.github.com>
2025-04-11 01:52:03 -05:00
Moritz Weichert
7b40007c37 feat: Enable discard-approval-on-plan for gitlab (#5388) 2025-03-10 22:08:22 +00:00
Pierre Guinoiseau
90b1b13b71 feat: Add support for GitLab groups (#4001)
Signed-off-by: Pierre Guinoiseau <pierre@guinoiseau.nz>
2025-01-25 18:39:37 +00:00
Lukas Aldershaab
6642a885b6 feat: Add rate limit handling for GitHub client (#5226)
Signed-off-by: Lukas Peter Aldershaab <lukas.aldershaab@lego.com>
Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com>
2025-01-22 00:08:00 -05:00
renovate[bot]
d473fe0092 fix(deps): update module github.com/google/go-github/v66 to v68 in go.mod (main) (#5209)
Signed-off-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Rui Chen <rui@chenrui.dev>
2024-12-31 18:45:20 +00:00
Rui Chen
129c5f04ee chore(deps): update alpine to 3.21.0, ca-certificates to 20241010, go/golangci-lint to latest (#5166)
Signed-off-by: Rui Chen <rui@chenrui.dev>
2024-12-15 15:26:33 -05:00
Simon Heather
e468a23e0b feat: Refine the Atlantis Info Message Logging (#5034)
Signed-off-by: Simon Heather <32168619+X-Guardian@users.noreply.github.com>
2024-11-19 12:54:55 -05:00
Roma Ryzhyi
b975301b2b fix: Fix GitHub pull request mergeability for multiple required workflow runs (#5057)
Signed-off-by: Roman Ryzhyi <ryzhyi.r@ajax.systems>
2024-11-19 09:52:53 +00:00
renovate[bot]
fca4be1820 fix(deps): update module github.com/google/go-github/v65 to v66 in go.mod (main) (#5086)
Signed-off-by: X-Guardian <simonheather99@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: X-Guardian <simonheather99@gmail.com>
2024-11-16 14:25:31 +00:00
bakayolo
841f7b4277 feat: add ignore-vcs-status-names (github only) (#4978)
Signed-off-by: bakayolo <benjamin.apprederisse@gmail.com>
2024-11-04 22:04:13 +00:00
Henrik Lundström
e4dea0311d fix: Ignore apply check(s) even if missing from rollup when determining mergeability for GitHub (#4974)
Signed-off-by: Henrik Lundström <henrik94lundstrom@gmail.com>
2024-11-04 17:59:23 +00:00
Alexey Kosenko
13fa635523 feat(automerge): implement GitHub --auto-merge-method flag for apply command (#4895)
Signed-off-by: a1k0u <alko7enko@gmail.com>
Signed-off-by: X-Guardian <simonheather99@gmail.com>
2024-11-02 20:09:17 +00:00
renovate[bot]
50ace7de5c fix(deps): update module github.com/google/go-github/v63 to v65 in go.mod (main) (#4968)
Signed-off-by: X-Guardian <simonheather99@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: X-Guardian <simonheather99@gmail.com>
2024-11-02 15:14:55 +00:00
Benoit Toulme
7f4a4207d1 fix: fix broken formatting of first comment in case of command output truncation (#4980)
Co-authored-by: PePe Amengual <2208324+jamengual@users.noreply.github.com>
2024-10-24 13:03:24 +01:00
nitrocode
1c1c50556f chore(deps): upgrade go-github 63.x (#4943)
Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-23 12:36:24 -05:00
benoittoulme
6b52bd7738 chore: use markdown to display github comments truncation header (#4885)
Co-authored-by: Rui Chen <rui@chenrui.dev>
2024-09-12 16:00:11 -04:00
Henrik Lundström
ed7b744695 fix: GitHub mergeability bypassing apply (#4193) 2024-09-04 19:36:24 -07:00
David Glasser
5a918e382c feat: Add --max-comments-per-command configuration (#3905)
Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
Co-authored-by: Benoit Toulme <benoit.toulme@gmail.com>
2024-06-26 23:13:09 -04:00
Pierre Guinoiseau
82bec78dff feat: Add option to lock on apply instead of plan (#3879)
Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
2024-05-16 22:27:27 -07:00
Simon Heather
b221fdc0af feat: Refine the logging in the Working Dir Package (#4294)
Co-authored-by: Dylan Page <dylan.page@autodesk.com>
2024-03-27 16:20:45 +00:00
renovate[bot]
6884238cd1 fix(deps): update module github.com/google/go-github/v58 to v59 in go.mod (main) (#4241)
* fix(deps): update module github.com/google/go-github/v58 to v59 in go.mod

* Update fixtures.go

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
2024-02-27 23:47:57 -06:00
Simon Heather
67b5740053 feat: Refine The Atlantis VCS Logging Configuration (#4285)
* Refine VCS Logging

* Remove github/gitlab client logger

* Remove fmtLogSrc from instrumented_client and format

* Add staticcheck lint exception for NewGitHubClient

* Fix tests
2024-02-26 13:07:41 -05:00
renovate[bot]
ef766d2ec1 fix(deps): update module github.com/google/go-github/v57 to v58 in go.mod (main) (#4138)
* fix(deps): update module github.com/google/go-github/v57 to v58 in go.mod

* Update remaining go-github to v58

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Luke Massa <lmassa@tripadvisor.com>
2024-01-19 10:30:38 -05:00
Simon Heather
31802675da fix: Atlantis Does Not Consider the Plan Directory When Hiding Previous Plan Comments (#4012)
* Fix Hide Previous Plan Comments

* Update GitLab client tests

* Update GitLab client test

* Update github client test

* Add nolint: errcheck to test

* format github_client.go
2023-12-29 13:15:17 -05:00
Adam Kafka
f5d92c60b5 fix: Prevent panics when logging HTTP response status in github and gitlab client (#4082)
Fix potential nil pointers. See https://github.com/runatlantis/atlantis/issues/4081 for context.
2023-12-22 11:36:04 -05:00
renovate[bot]
d93f85a0c3 fix(deps): update module github.com/google/go-github/v54 to v57 in go.mod (main) (#4032)
* fix(deps): update module github.com/google/go-github/v54 to v57 in go.mod

* fix(deps): go-github v57 in server/events/vcs/testdata/fixtures.go

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
2023-12-12 00:21:42 +00:00
Gabriel Martinez
56e38b4151 chore(atlantis): fix linter errors (#3690)
* chore(atlantis): fix linter errors

* fix superfluous-else

* revert gitlab check

* ignore stub funcs on azuredevops_client

* remove fetch-depth

* remove fail_on_error

* fix plan_step_runner_test.go

* more lint fixes

---------

Co-authored-by: Dylan Page <dylan.page@autodesk.com>
2023-12-11 19:02:16 +00:00
Simon Heather
edc9bd9262 feat: Improve GitHub and GitLab Debug Logging (#3876)
* Improve GitHub and GitLab Debug Logging

* Fix formatting

* Fix g.client.Repositories.Get debug message

* Update gitlab_client_test with logger

---------

Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
2023-10-20 08:49:57 -07:00
Ghais Zaher
80ecc38273 feat: disable autoplan label (#3649)
* feat: disable autoplan label

* documentation

* revert unrelated change

* fix property

* gitlab and github

* dd more test

* small fixes

* add tests for github and gitlab clients

* fix: remove unrelated comments

* fmt

---------

Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
2023-09-25 13:43:35 -04:00
Luke Massa
70c9f17007 Revert "fix(deps): update module github.com/google/go-github/v54 to v55 in go.mod (#3743)" (#3748)
This reverts commit 3a2a244272.
2023-09-06 21:15:56 -07:00
renovate[bot]
3a2a244272 fix(deps): update module github.com/google/go-github/v54 to v55 in go.mod (#3743)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-09-06 21:12:07 +00:00
renovate[bot]
55e24fbbf5 fix(deps): update module github.com/google/go-github/v53 to v54 in go.mod (#3676)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-17 00:41:13 +00:00
Artur Rodrigues
049c146b2c fix(github): prevent null pointer dereferencing when using AllowMergeableBypassApply with no required checks on branch protection (#3672)
* Implement test for allow mergeable bypass apply with no branch protection checks

* Report true combined status if no branch protection required status checks

* Remove warning on feature flag utilization
2023-08-15 10:11:37 -07:00
Torben Tretau
62271955de fix(github): Mergeable requirement for fork PRs (#3620)
While using a PR from a fork and the "Github allow mergeable bypass apply" flag, the mergeable checks were run with the wrong owner in the request, leading to 404. By choosing the owner from the head repo data it should work both, for fork PRs and in-repo PRs.

Co-authored-by: Dylan Page <dylan.page@autodesk.com>
2023-08-01 02:25:31 +00:00
Simon Heather
86607d8aeb feat: Add GitLab Reaction Emojis on MR Comments (#3456)
* Add GitLab Reaction Emoji

* Update docs

* update docs

* Update event_parser_test
2023-06-12 22:27:42 -05:00
renovate[bot]
1d91dfb083 fix(deps): update module github.com/google/go-github/v52 to v53 in go.mod (#3495)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-07 03:41:38 +00:00
renovate[bot]
cc2d0c16e3 fix(deps): update module github.com/google/go-github/v51 to v52 in go.mod (#3346)
* fix(deps): update module github.com/google/go-github/v51 to v52 in go.mod

* Update fixtures.go

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
2023-04-30 03:07:33 +00:00
Marcus Ramberg
f8b293ada0 feat: Github reaction emojis on PR comments (#2706)
* feat: Basic implementation of github reactions on PRs

Adds eyes whenever it detects an `atlantis` command.

* feat: Make the emoji reaction configurable

* tests: Add a mocked test for EmojiReaction being called in github

* ci: Disable revive linter for stubs
2023-04-25 17:22:51 -04:00
Dylan Page
34ad9e901d fix: revert branch protection feature causing breaking change
Reverts "fix(github): branch protection not supported (#3276)"
Reverts "fix: allow Require Linear History when selecting merge method (#3211)"
Closes #3320
2023-04-11 16:48:39 -04:00
renovate[bot]
763f017169 fix(deps): update module github.com/google/go-github/v50 to v51 in go.mod (#3316)
* fix(deps): update module github.com/google/go-github/v50 to v51 in go.mod

* Update fixtures.go

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
2023-04-11 00:36:40 -05:00
Tymofii Polekhin
ebc06c19c6 fix(github): branch protection not supported (#3276)
* fix: github branch protection not supported

* fix: typo protectionAvailable
2023-03-30 11:32:59 -05:00
Tymofii Polekhin
7a33828227 fix: allow Require Linear History when selecting merge method (#3211)
* fix: account for Require Linear History when selecting merge method

* fix logic and add tests

* add nolint hints for w.Write

---------

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
2023-03-18 17:43:11 -05:00
Ken Kaizu
acc8ef6abc fix(deps): update module github.com/google/go-github/v49 to v50 (#3074) 2023-01-30 22:25:56 -06:00
renovate[bot]
fbdd0c729a fix(deps): update module github.com/google/go-github/v48 to v49 (#2928)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-05 00:22:37 -05:00