Leandro López df04456325 Return error on InstrumentedClient.MergePull (#3839) ...

When the underlying GitHub Client returns an error it gets swallowed
in this wrapper method. Not only that but also the emitted metrics are
wrong, as it counts one error AND success at the same time.

We've found this @grafana when using Atlantis in a massive repository
with many changes per minute, and sometimes Atlantis leave a comment
saying it's automatically merging but then nothing happens. But
checking the logs, we've found the following error message:

    Unable to merge pull, error: merging pull request: PUT
    https://api.github.com/repos/grafana/redacted/pulls/666/merge: 405
    Base branch was modified. Review and try the merge again. []

And because the error is swallowed and `InstrumentedClient.MergePull`
returns `nil`, then `Automerger` fails to leave a comment saying
merging failed.

2023-10-09 14:18:07 -07:00

..

controllers

fix: Running 'atlantis unlock' on a PR Causes The Whole Working Directory to be Deleted (#3751)

2023-09-11 11:00:12 -04:00

core

fix(multienv): allow commas and quoted values (#3542)

2023-10-06 12:05:19 -04:00

events

Return error on InstrumentedClient.MergePull (#3839)

2023-10-09 14:18:07 -07:00

jobs

fix: make go-generate now creates working mocks out of the box (#3802)

2023-10-06 11:04:34 -04:00

logging

Fix Simple Logger Log Function (#3631)

2023-07-30 15:33:30 -04:00

metrics

chore(deps): bump tally to v4 (#3498)

2023-06-08 21:57:46 -04:00

recovery

chore(test): add no test dir tests, rename testdata dir (#2986)

2023-01-15 23:14:23 -06:00

scheduled

fix(deps): update module github.com/petergtz/pegomock/v3 to v4 (#3534)

2023-06-20 15:05:23 -04:00

static

feat: Add username to main lock screen (#3597)

2023-07-17 16:18:52 +00:00

utils

feat: Add check for misspelled executable name command (#3059)

2023-02-22 00:45:14 +00:00

middleware.go

Upgrade negroni to v3 (#2867)

2022-12-23 11:58:10 -06:00

router_test.go

chore: move CommandContext and CommandResult to models (#193) (#2093)

2022-03-21 10:36:13 -07:00

router.go

feat: Add pre and post workflow hook status (#2441)

2022-12-19 14:20:34 -06:00

server_test.go

fix(deps): update module github.com/petergtz/pegomock/v3 to v4 (#3534)

2023-06-20 15:05:23 -04:00

server.go

feat: disable autoplan label (#3649)

2023-09-25 13:43:35 -04:00

user_config_test.go

feat: state rm (#2880)

2023-01-18 22:02:18 -06:00

user_config.go

feat: disable autoplan label (#3649)

2023-09-25 13:43:35 -04:00