mirror of
https://git.vectorsigma.ru/public/atlantis.git
synced 2026-08-04 14:38:43 +00:00
58493f3402
-target doesn't work with terraform apply when the apply is being run on a planfile (which is how Atlantis runs plan). We should give the user an error if they attempt this. Fixes #399
70 lines
2.1 KiB
Go
70 lines
2.1 KiB
Go
package runtime
|
||
|
||
import (
|
||
"errors"
|
||
"fmt"
|
||
"os"
|
||
"path/filepath"
|
||
"strings"
|
||
|
||
"github.com/hashicorp/go-version"
|
||
"github.com/runatlantis/atlantis/server/events/models"
|
||
)
|
||
|
||
// ApplyStepRunner runs `terraform apply`.
|
||
type ApplyStepRunner struct {
|
||
TerraformExecutor TerraformExec
|
||
}
|
||
|
||
func (a *ApplyStepRunner) Run(ctx models.ProjectCommandContext, extraArgs []string, path string) (string, error) {
|
||
if a.hasTargetFlag(ctx, extraArgs) {
|
||
return "", errors.New("cannot run apply with -target because we are applying an already generated plan. Instead, run -target with atlantis plan")
|
||
}
|
||
|
||
planPath := filepath.Join(path, GetPlanFilename(ctx.Workspace, ctx.ProjectConfig))
|
||
stat, err := os.Stat(planPath)
|
||
if err != nil || stat.IsDir() {
|
||
return "", fmt.Errorf("no plan found at path %q and workspace %q–did you run plan?", ctx.RepoRelDir, ctx.Workspace)
|
||
}
|
||
|
||
// NOTE: we need to quote the plan path because Bitbucket Server can
|
||
// have spaces in its repo owner names which is part of the path.
|
||
tfApplyCmd := append(append(append([]string{"apply", "-input=false", "-no-color"}, extraArgs...), ctx.CommentArgs...), fmt.Sprintf("%q", planPath))
|
||
var tfVersion *version.Version
|
||
if ctx.ProjectConfig != nil && ctx.ProjectConfig.TerraformVersion != nil {
|
||
tfVersion = ctx.ProjectConfig.TerraformVersion
|
||
}
|
||
out, tfErr := a.TerraformExecutor.RunCommandWithVersion(ctx.Log, path, tfApplyCmd, tfVersion, ctx.Workspace)
|
||
|
||
// If the apply was successful, delete the plan.
|
||
if tfErr == nil {
|
||
ctx.Log.Info("apply successful, deleting planfile")
|
||
if err := os.Remove(planPath); err != nil {
|
||
ctx.Log.Warn("failed to delete planfile after successful apply: %s", err)
|
||
}
|
||
}
|
||
return out, tfErr
|
||
}
|
||
|
||
func (a *ApplyStepRunner) hasTargetFlag(ctx models.ProjectCommandContext, extraArgs []string) bool {
|
||
isTargetFlag := func(s string) bool {
|
||
if s == "-target" {
|
||
return true
|
||
}
|
||
split := strings.Split(s, "=")
|
||
return split[0] == "-target"
|
||
}
|
||
|
||
for _, arg := range ctx.CommentArgs {
|
||
if isTargetFlag(arg) {
|
||
return true
|
||
}
|
||
}
|
||
for _, arg := range extraArgs {
|
||
if isTargetFlag(arg) {
|
||
return true
|
||
}
|
||
}
|
||
return false
|
||
}
|