PePe Amengual 900f00be65 fix: clear pending VCS status when silence flags enabled and no projects found ...

This fixes issue #5389 where PRs were getting stuck with pending status when
ATLANTIS_SILENCE_VCS_STATUS_NO_PLANS and ATLANTIS_SILENCE_VCS_STATUS_NO_PROJECTS
were enabled and no projects matched when_modified patterns.

Root cause:
- PR #5242 (commit be060636) introduced early pending status setting in command_runner.go
- When silence flags are enabled and no projects are found, the pending status was never cleared
- This left PRs stuck in pending state, blocking auto-merge functionality

Solution:
- Modified plan_command_runner.go to clear pending status even when silence flags are enabled
- Added else blocks to both autoplan and manual plan paths
- When silence is enabled but no projects found, update status to success (0/0) to clear pending
- Added comprehensive test to prevent regression

Testing:
- Updated existing test expectation for silence flag behavior
- Added new test TestPlanCommandRunner_SilenceFlagsClearsPendingStatus
- All existing tests continue to pass

2025-08-14 23:02:10 -07:00

..

controllers

feat: Comment on pull request if pre-workflow hooks fail (#5659)

2025-08-07 11:43:33 -07:00

core

revert: "convert gopkg.in/yaml.v3 to goccy/go-yaml (#5579)" (#5683)

2025-07-30 16:55:35 -07:00

events

fix: clear pending VCS status when silence flags enabled and no projects found

2025-08-14 23:02:10 -07:00

jobs

chore: Regenerates mock files with pegomock v4.1.0 (#5090)

2024-11-16 15:00:42 +00:00

logging

chore: Regenerates mock files with pegomock v4.1.0 (#5090)

2024-11-16 15:00:42 +00:00

metrics

fix(deps): update module github.com/uber-go/tally/v4 to v4.1.16 in go.mod (main) (#4228)

2024-11-08 23:41:26 +00:00

recovery

chore(test): add no test dir tests, rename testdata dir (#2986)

2023-01-15 23:14:23 -06:00

scheduled

chore: Regenerates mock files with pegomock v4.1.0 (#5090)

2024-11-16 15:00:42 +00:00

static

chore(deps): Update xterm.js to v5.3.0 and enable Smooth Scrolling (#4257)

2024-02-25 15:24:04 +00:00

utils

fix: os.Remove should ignore non existing errors (#4502)

2024-05-04 14:59:22 -05:00

middleware.go

Upgrade negroni to v3 (#2867)

2022-12-23 11:58:10 -06:00

router_test.go

chore(lint): linting the codebase (#4668)

2024-06-17 11:22:30 -04:00

router.go

feat: Add pre and post workflow hook status (#2441)

2022-12-19 14:20:34 -06:00

server_test.go

chore: Add Struct required tags and Server Struct Validator (#5371)

2025-03-09 11:34:48 +00:00

server.go

feat: add HTTP pprof endpoints (#5363)

2025-05-09 09:20:24 -07:00

user_config_test.go

feat: add http webhook (#5233)

2025-01-22 19:39:20 -08:00

user_config.go

feat: add HTTP pprof endpoints (#5363)

2025-05-09 09:20:24 -07:00