mirror of
https://git.vectorsigma.ru/public/atlantis.git
synced 2026-08-01 23:08:42 +00:00
* mod: rename updateCommitStatus func * feat: add PlannedNoChangesPlanStatus * Add skipApplyNoChanges option to PlanCommandRunner * Add skipApplyNoChanges option to ApplyCommandRunner * Add --skip-apply-no-changes flag * Fix typo Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com> * Rename --skip-apply-no-changes flag * Refactor updateCommitStatus functions * chore(docs): add detailed use case for the flag * test: add plan_command_runner set apply status * feat: set apply status to successful by default when result is 'No Changes' --------- Co-authored-by: chroju <chroju@users.noreply.github.com> Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
298 lines
7.3 KiB
Go
298 lines
7.3 KiB
Go
package events
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/runatlantis/atlantis/server/events/command"
|
|
"github.com/runatlantis/atlantis/server/events/models"
|
|
. "github.com/runatlantis/atlantis/testing"
|
|
)
|
|
|
|
func TestApplyUpdateCommitStatus(t *testing.T) {
|
|
cases := map[string]struct {
|
|
cmd command.Name
|
|
pullStatus models.PullStatus
|
|
expStatus models.CommitStatus
|
|
expNumSuccess int
|
|
expNumTotal int
|
|
}{
|
|
"apply, one pending": {
|
|
cmd: command.Apply,
|
|
pullStatus: models.PullStatus{
|
|
Projects: []models.ProjectStatus{
|
|
{
|
|
Status: models.PlannedPlanStatus,
|
|
},
|
|
{
|
|
Status: models.AppliedPlanStatus,
|
|
},
|
|
},
|
|
},
|
|
expStatus: models.PendingCommitStatus,
|
|
expNumSuccess: 1,
|
|
expNumTotal: 2,
|
|
},
|
|
"apply, all successful": {
|
|
cmd: command.Apply,
|
|
pullStatus: models.PullStatus{
|
|
Projects: []models.ProjectStatus{
|
|
{
|
|
Status: models.AppliedPlanStatus,
|
|
},
|
|
{
|
|
Status: models.AppliedPlanStatus,
|
|
},
|
|
},
|
|
},
|
|
expStatus: models.SuccessCommitStatus,
|
|
expNumSuccess: 2,
|
|
expNumTotal: 2,
|
|
},
|
|
"apply, one errored, one pending": {
|
|
cmd: command.Apply,
|
|
pullStatus: models.PullStatus{
|
|
Projects: []models.ProjectStatus{
|
|
{
|
|
Status: models.AppliedPlanStatus,
|
|
},
|
|
{
|
|
Status: models.ErroredApplyStatus,
|
|
},
|
|
{
|
|
Status: models.PlannedPlanStatus,
|
|
},
|
|
},
|
|
},
|
|
expStatus: models.FailedCommitStatus,
|
|
expNumSuccess: 1,
|
|
expNumTotal: 3,
|
|
},
|
|
"apply, one planned no changes": {
|
|
cmd: command.Apply,
|
|
pullStatus: models.PullStatus{
|
|
Projects: []models.ProjectStatus{
|
|
{
|
|
Status: models.AppliedPlanStatus,
|
|
},
|
|
{
|
|
Status: models.PlannedNoChangesPlanStatus,
|
|
},
|
|
},
|
|
},
|
|
expStatus: models.SuccessCommitStatus,
|
|
expNumSuccess: 2,
|
|
expNumTotal: 2,
|
|
},
|
|
}
|
|
|
|
for name, c := range cases {
|
|
t.Run(name, func(t *testing.T) {
|
|
csu := &MockCSU{}
|
|
cr := &ApplyCommandRunner{
|
|
commitStatusUpdater: csu,
|
|
}
|
|
cr.updateCommitStatus(&command.Context{}, c.pullStatus)
|
|
Equals(t, models.Repo{}, csu.CalledRepo)
|
|
Equals(t, models.PullRequest{}, csu.CalledPull)
|
|
Equals(t, c.expStatus, csu.CalledStatus)
|
|
Equals(t, c.cmd, csu.CalledCommand)
|
|
Equals(t, c.expNumSuccess, csu.CalledNumSuccess)
|
|
Equals(t, c.expNumTotal, csu.CalledNumTotal)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestPlanUpdatePlanCommitStatus(t *testing.T) {
|
|
cases := map[string]struct {
|
|
cmd command.Name
|
|
pullStatus models.PullStatus
|
|
expStatus models.CommitStatus
|
|
expNumSuccess int
|
|
expNumTotal int
|
|
}{
|
|
"single plan success": {
|
|
cmd: command.Plan,
|
|
pullStatus: models.PullStatus{
|
|
Projects: []models.ProjectStatus{
|
|
{
|
|
Status: models.PlannedPlanStatus,
|
|
},
|
|
},
|
|
},
|
|
expStatus: models.SuccessCommitStatus,
|
|
expNumSuccess: 1,
|
|
expNumTotal: 1,
|
|
},
|
|
"one plan error, other errors": {
|
|
cmd: command.Plan,
|
|
pullStatus: models.PullStatus{
|
|
Projects: []models.ProjectStatus{
|
|
{
|
|
Status: models.ErroredPlanStatus,
|
|
},
|
|
{
|
|
Status: models.PlannedPlanStatus,
|
|
},
|
|
{
|
|
Status: models.AppliedPlanStatus,
|
|
},
|
|
{
|
|
Status: models.ErroredApplyStatus,
|
|
},
|
|
},
|
|
},
|
|
expStatus: models.FailedCommitStatus,
|
|
expNumSuccess: 3,
|
|
expNumTotal: 4,
|
|
},
|
|
}
|
|
|
|
for name, c := range cases {
|
|
t.Run(name, func(t *testing.T) {
|
|
csu := &MockCSU{}
|
|
cr := &PlanCommandRunner{
|
|
commitStatusUpdater: csu,
|
|
}
|
|
cr.updateCommitStatus(&command.Context{}, c.pullStatus, command.Plan)
|
|
Equals(t, models.Repo{}, csu.CalledRepo)
|
|
Equals(t, models.PullRequest{}, csu.CalledPull)
|
|
Equals(t, c.expStatus, csu.CalledStatus)
|
|
Equals(t, c.cmd, csu.CalledCommand)
|
|
Equals(t, c.expNumSuccess, csu.CalledNumSuccess)
|
|
Equals(t, c.expNumTotal, csu.CalledNumTotal)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestPlanUpdateApplyCommitStatus(t *testing.T) {
|
|
cases := map[string]struct {
|
|
cmd command.Name
|
|
pullStatus models.PullStatus
|
|
expStatus models.CommitStatus
|
|
expNumSuccess int
|
|
expNumTotal int
|
|
}{
|
|
"all plans success with no changes": {
|
|
cmd: command.Apply,
|
|
pullStatus: models.PullStatus{
|
|
Projects: []models.ProjectStatus{
|
|
{
|
|
Status: models.PlannedNoChangesPlanStatus,
|
|
},
|
|
{
|
|
Status: models.PlannedNoChangesPlanStatus,
|
|
},
|
|
},
|
|
},
|
|
expStatus: models.SuccessCommitStatus,
|
|
expNumSuccess: 2,
|
|
expNumTotal: 2,
|
|
},
|
|
"one plan, one plan success with no changes": {
|
|
cmd: command.Apply,
|
|
pullStatus: models.PullStatus{
|
|
Projects: []models.ProjectStatus{
|
|
{
|
|
Status: models.PlannedNoChangesPlanStatus,
|
|
},
|
|
{
|
|
Status: models.PlannedPlanStatus,
|
|
},
|
|
},
|
|
},
|
|
expStatus: models.PendingCommitStatus,
|
|
expNumSuccess: 1,
|
|
expNumTotal: 2,
|
|
},
|
|
"one plan, one apply, one plan success with no changes": {
|
|
cmd: command.Apply,
|
|
pullStatus: models.PullStatus{
|
|
Projects: []models.ProjectStatus{
|
|
{
|
|
Status: models.PlannedNoChangesPlanStatus,
|
|
},
|
|
{
|
|
Status: models.AppliedPlanStatus,
|
|
},
|
|
{
|
|
Status: models.PlannedPlanStatus,
|
|
},
|
|
},
|
|
},
|
|
expStatus: models.PendingCommitStatus,
|
|
expNumSuccess: 2,
|
|
expNumTotal: 3,
|
|
},
|
|
"one apply error, one apply, one plan success with no changes": {
|
|
cmd: command.Apply,
|
|
pullStatus: models.PullStatus{
|
|
Projects: []models.ProjectStatus{
|
|
{
|
|
Status: models.PlannedNoChangesPlanStatus,
|
|
},
|
|
{
|
|
Status: models.AppliedPlanStatus,
|
|
},
|
|
{
|
|
Status: models.ErroredApplyStatus,
|
|
},
|
|
},
|
|
},
|
|
expStatus: models.FailedCommitStatus,
|
|
expNumSuccess: 2,
|
|
expNumTotal: 3,
|
|
},
|
|
}
|
|
|
|
for name, c := range cases {
|
|
t.Run(name, func(t *testing.T) {
|
|
csu := &MockCSU{}
|
|
cr := &PlanCommandRunner{
|
|
commitStatusUpdater: csu,
|
|
}
|
|
cr.updateCommitStatus(&command.Context{}, c.pullStatus, command.Apply)
|
|
Equals(t, models.Repo{}, csu.CalledRepo)
|
|
Equals(t, models.PullRequest{}, csu.CalledPull)
|
|
Equals(t, c.expStatus, csu.CalledStatus)
|
|
Equals(t, c.cmd, csu.CalledCommand)
|
|
Equals(t, c.expNumSuccess, csu.CalledNumSuccess)
|
|
Equals(t, c.expNumTotal, csu.CalledNumTotal)
|
|
})
|
|
}
|
|
}
|
|
|
|
type MockCSU struct {
|
|
CalledRepo models.Repo
|
|
CalledPull models.PullRequest
|
|
CalledStatus models.CommitStatus
|
|
CalledCommand command.Name
|
|
CalledNumSuccess int
|
|
CalledNumTotal int
|
|
}
|
|
|
|
func (m *MockCSU) UpdateCombinedCount(repo models.Repo, pull models.PullRequest, status models.CommitStatus, command command.Name, numSuccess int, numTotal int) error {
|
|
m.CalledRepo = repo
|
|
m.CalledPull = pull
|
|
m.CalledStatus = status
|
|
m.CalledCommand = command
|
|
m.CalledNumSuccess = numSuccess
|
|
m.CalledNumTotal = numTotal
|
|
return nil
|
|
}
|
|
|
|
func (m *MockCSU) UpdateCombined(repo models.Repo, pull models.PullRequest, status models.CommitStatus, command command.Name) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *MockCSU) UpdateProject(ctx command.ProjectContext, cmdName command.Name, status models.CommitStatus, url string, result *command.ProjectResult) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *MockCSU) UpdatePreWorkflowHook(pull models.PullRequest, status models.CommitStatus, hookDescription string, runtimeDescription string, url string) error {
|
|
return nil
|
|
}
|
|
|
|
func (m *MockCSU) UpdatePostWorkflowHook(pull models.PullRequest, status models.CommitStatus, hookDescription string, runtimeDescription string, url string) error {
|
|
return nil
|
|
}
|