Masayuki Morita 2600708fba Validate base branches in DefaultCommandRunner (#1768) ...

Fixes #1539

The branch matcher feature has been introduced in #1383, but the current
implementation was broken and doesn't work at all (#1539).

If my understanding is correct, there are two problems:

(1) The `GlobalCfg` has a default `Repo` instance which always matches
any repositries and branches. Therefore the branch matcher never be
functional.
(2) Validating base branches in
`DefaultPreWorkflowHooksCommandRunner.RunPreHooks()` implicitly assumed
that users customize `pre_workflow_hooks`, but the assumption isn't
always true because it defaults to empty.

For (1), I added a new method `MatchingRepo()` to `GlobalCfg` to check
`BranchMatches()` for a single `Repo` instance.

For (2), I moved validating branch to
`DefaultCommandRunner.validateCtxAndComment()`. Since the method has
already validated meta data of pull request, I think it's suitable place
to check base branches, but please let me know if there is anywhere more
suitable.

2021-08-30 15:13:59 -07:00

..

events

Validate base branches in DefaultCommandRunner (#1768)

2021-08-30 15:13:59 -07:00

templates

Refactor controllers into package. (#1597)

2021-06-01 11:58:01 -07:00

github_app_controller.go

Refactor controllers into package. (#1597)

2021-06-01 11:58:01 -07:00

locks_controller_test.go

Move core workflow packages under core. (#1684)

2021-07-01 12:54:44 -07:00

locks_controller.go

Move core workflow packages under core. (#1684)

2021-07-01 12:54:44 -07:00

status_controller_test.go

Refactor controllers into package. (#1597)

2021-06-01 11:58:01 -07:00

status_controller.go

Refactor controllers into package. (#1597)

2021-06-01 11:58:01 -07:00