diff --git a/pkg/cli/cert/cert.go b/pkg/cli/cert/cert.go index 34ae425f78..42402bc302 100644 --- a/pkg/cli/cert/cert.go +++ b/pkg/cli/cert/cert.go @@ -98,13 +98,13 @@ func check(app *cli.Context, cfg *cmds.Server) error { switch outFmt { case "text": for service, files := range fileMap { - logrus.Info("Checking certificates for " + service) + logrus.Infof("Checking certificates for %s", service) for _, file := range files { // ignore errors, as some files may not exist, or may not contain certs. // Only check whatever exists and has certs. certs, err := certutil.CertsFromFile(file) if err != nil { - logrus.Debugf(err.Error()) + logrus.Debugf("%v", err) continue } for _, cert := range certs { @@ -130,7 +130,7 @@ func check(app *cli.Context, cfg *cmds.Server) error { for _, file := range files { certs, err := certutil.CertsFromFile(file) if err != nil { - logrus.Debugf(err.Error()) + logrus.Debugf("%v", err) continue } for _, cert := range certs { diff --git a/pkg/clientaccess/token.go b/pkg/clientaccess/token.go index e64d2d9d54..b46afcd501 100644 --- a/pkg/clientaccess/token.go +++ b/pkg/clientaccess/token.go @@ -538,7 +538,7 @@ func readBody(resp *http.Response) ([]byte, error) { warnings, _ := net.ParseWarningHeaders(resp.Header["Warning"]) for _, warning := range warnings { if warning.Code == 299 && len(warning.Text) != 0 { - logrus.Warnf(warning.Text) + logrus.Warnf("%s", warning.Text) } } diff --git a/pkg/cluster/bootstrap.go b/pkg/cluster/bootstrap.go index 91f0df7a1f..2733c6ceaa 100644 --- a/pkg/cluster/bootstrap.go +++ b/pkg/cluster/bootstrap.go @@ -348,7 +348,7 @@ func (c *Cluster) ReconcileBootstrapData(ctx context.Context, buf io.ReadSeeker, serverTLSDir := filepath.Join(c.config.DataDir, "tls") tlsBackupDir := filepath.Join(c.config.DataDir, "tls-"+strconv.Itoa(int(time.Now().Unix()))) - logrus.Infof("Cluster reset: backing up certificates directory to " + tlsBackupDir) + logrus.Infof("Cluster reset: backing up certificates directory to %s", tlsBackupDir) if _, err := os.Stat(serverTLSDir); err != nil { return pkgerrors.WithMessage(err, "cluster reset failed to stat server TLS dir") diff --git a/pkg/node/controller.go b/pkg/node/controller.go index 943a8d7e0e..47d392a877 100644 --- a/pkg/node/controller.go +++ b/pkg/node/controller.go @@ -88,7 +88,7 @@ func (h *handler) updateCoreDNSConfigMap(nodeName, hostName, nodeIPv4, nodeIPv6 nodeIPv4 = "" nodeIPv6 = "" } else if nodeIPv4 == "" && nodeIPv6 == "" { - logrus.Errorf("No InternalIP addresses found for node " + nodeName) + logrus.Errorf("No InternalIP addresses found for node %s", nodeName) return nil } diff --git a/pkg/util/args_test.go b/pkg/util/args_test.go index 40f91106c9..8dc140a534 100644 --- a/pkg/util/args_test.go +++ b/pkg/util/args_test.go @@ -37,7 +37,7 @@ func Test_UnitAddFeatureGate(t *testing.T) { t.Run(tt.name, func(t *testing.T) { got := AddFeatureGate(tt.args.currentArg, tt.args.featureGate) if got != tt.want { - t.Errorf("error, should be " + tt.want + ", but got " + got) + t.Errorf("error, should be %s, but got %s", tt.want, got) } }) }