From 9505f7ff3b47a79a1300d9bc5333fc081bca1a95 Mon Sep 17 00:00:00 2001 From: manuelbuil Date: Wed, 2 Apr 2025 13:10:11 +0200 Subject: [PATCH] Add error in certificate check Signed-off-by: manuelbuil --- pkg/cli/cert/cert.go | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/pkg/cli/cert/cert.go b/pkg/cli/cert/cert.go index 3a1ea569da..34ae425f78 100644 --- a/pkg/cli/cert/cert.go +++ b/pkg/cli/cert/cert.go @@ -102,7 +102,11 @@ func check(app *cli.Context, cfg *cmds.Server) error { for _, file := range files { // ignore errors, as some files may not exist, or may not contain certs. // Only check whatever exists and has certs. - certs, _ := certutil.CertsFromFile(file) + certs, err := certutil.CertsFromFile(file) + if err != nil { + logrus.Debugf(err.Error()) + continue + } for _, cert := range certs { if now.Before(cert.NotBefore) { logrus.Errorf("%s: certificate %s is not valid before %s", file, cert.Subject, cert.NotBefore.Format(time.RFC3339)) @@ -124,7 +128,11 @@ func check(app *cli.Context, cfg *cmds.Server) error { fmt.Fprintf(w, "-----------\t-------\t------\t-------") for _, files := range fileMap { for _, file := range files { - certs, _ := certutil.CertsFromFile(file) + certs, err := certutil.CertsFromFile(file) + if err != nil { + logrus.Debugf(err.Error()) + continue + } for _, cert := range certs { baseName := filepath.Base(file) var status string