public/atlantis
1
0
Fork 0
mirror of https://git.vectorsigma.ru/public/atlantis.git synced 2026-07-28 21:38:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

style: run go fmt on modified files

Browse Source
This commit is contained in:
PePe Amengual
2025-08-14 23:05:55 -07:00
parent 900f00be65
commit 424500597c
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
server/events/plan_command_runner_test.go
View File

@@ -834,23 +834,23 @@ func TestPlanCommandRunner_SilenceFlagsClearsPendingStatus(t *testing.T) {
// Test the specific scenario from issue #5389:
// When silence flags are enabled and no projects match when_modified patterns,
// the pending status should be cleared instead of leaving the PR stuck.
// This test ensures that even when ATLANTIS_SILENCE_VCS_STATUS_NO_PLANS and
// ATLANTIS_SILENCE_VCS_STATUS_NO_PROJECTS are true, we still update the status
// to clear any pending state that was set earlier (e.g., in command_runner.go)
t.Run("silence flags with no projects should clear pending status", func(t *testing.T) {
RegisterMockTestingT(t)
_ = setup(t, func(tc *TestConfig) {
tc.SilenceNoProjects = true
tc.silenceVCSStatusNoProjects = true // This is the key flag
tc.silenceVCSStatusNoPlans = true // This is the key flag
tc.silenceVCSStatusNoProjects = true // This is the key flag
tc.silenceVCSStatusNoPlans = true // This is the key flag
})
modelPull := models.PullRequest{BaseRepo: testdata.GithubRepo, State: models.OpenPullState, Num: testdata.Pull.Num}
scopeNull, _, _ := metrics.NewLoggingScope(logging.NewNoopLogger(t), "atlantis")
ctx := &command.Context{
User: testdata.User,
Log: logging.NewNoopLogger(t),
@@ -859,23 +859,23 @@ func TestPlanCommandRunner_SilenceFlagsClearsPendingStatus(t *testing.T) {
HeadRepo: testdata.GithubRepo,
Trigger: command.AutoTrigger,
}
// Mock no projects found (simulating when_modified patterns not matching)
When(projectCommandBuilder.BuildAutoplanCommands(ctx)).ThenReturn([]command.ProjectContext{}, nil)
// This is the key test: when both conditions are true:
// 1. Silence flags are enabled
// 2. No projects are found
// We should STILL update the status to clear any pending state
// The plan runner is now configured with silence flags
// When it finds no projects, it should clear the pending status
// even though silence is enabled
// Run through the plan command (which will internally check for projects)
cmd := &events.CommentCommand{Name: command.Plan}
planCommandRunner.Run(ctx, cmd)
// CRITICAL VERIFICATION: With the fix, even with silence flags enabled,
// we should update the status to Success with 0/0 to clear pending state
// This prevents PRs from being stuck in pending state (issue #5389)